Allow timer and alarm sounds to be disabled #58

Merged

lost-rob0t merged 1 commit from feat/zara-timer-alarm-sounds into master

2026-07-19 08:33:35 +00:00

lost-rob0t commented

2026-07-19 08:30:22 +00:00

(Migrated from github.com)

Follow-up to #39 and #47.

What changed

accepts the exact unquoted disabled atom for timer and alarm sound settings
treats disabled playback as a successful no-op before path resolution or player launch
strictly rejects ambiguous/invalid disable values such as false, empty text, lists, and quoted "disabled"
documents the per-kind disable syntax in generated config guidance and the install wiki
adds focused tests for independent settings, zero player calls, enabled playback, and timer completion notification

Why

The existing feature allowed selecting sound files but did not provide a supported way to turn playback off. This adds the requested opt-out while preserving bundled enabled defaults.

Validation

focused Prolog sound/config tests passed
full required gate — 155 pytest tests and every scripts/test-*.sh passed
nix build — all five derivations built

No rebase was used.

Follow-up to #39 and #47. ## What changed - accepts the exact unquoted `disabled` atom for timer and alarm sound settings - treats disabled playback as a successful no-op before path resolution or player launch - strictly rejects ambiguous/invalid disable values such as `false`, empty text, lists, and quoted `"disabled"` - documents the per-kind disable syntax in generated config guidance and the install wiki - adds focused tests for independent settings, zero player calls, enabled playback, and timer completion notification ## Why The existing feature allowed selecting sound files but did not provide a supported way to turn playback off. This adds the requested opt-out while preserving bundled enabled defaults. ## Validation - focused Prolog sound/config tests passed - full required gate — 155 pytest tests and every `scripts/test-*.sh` passed - `nix build` — all five derivations built No rebase was used.