Fail closed on command execution errors #34

Merged
lost-rob0t merged 1 commit from fix/zara-003-fail-closed-commands into master 2026-07-18 20:12:23 +00:00
lost-rob0t commented 2026-07-18 20:11:34 +00:00 (Migrated from github.com)

What changed

  • removed the unconditional Prolog command success fallback
  • made failed launches and handler exceptions fail the command predicate
  • propagated intent, timer, and config execution failures through PrologEngine
  • routed failed wake commands to the agent exactly once
  • added deterministic Prolog and Python command-routing gates

Why

Unknown, malformed, or failed commands previously returned success and produced Executed: confirmations even when no side effect occurred.

Impact

Unsupported and failed commands now fail closed and enter the existing conversational fallback path instead of reporting false success.

Validation

  • nix develop -c scripts/test-command-routing.sh
  • nix develop -c pytest (11 passed)

Closes #4

## What changed - removed the unconditional Prolog command success fallback - made failed launches and handler exceptions fail the command predicate - propagated intent, timer, and config execution failures through `PrologEngine` - routed failed wake commands to the agent exactly once - added deterministic Prolog and Python command-routing gates ## Why Unknown, malformed, or failed commands previously returned success and produced `Executed:` confirmations even when no side effect occurred. ## Impact Unsupported and failed commands now fail closed and enter the existing conversational fallback path instead of reporting false success. ## Validation - `nix develop -c scripts/test-command-routing.sh` - `nix develop -c pytest` (11 passed) Closes #4
Sign in to join this conversation.
No description provided.