nsaspy/zara
1
0
Fork 0
Code Issues 95 Pull requests 18 Projects Releases Packages Wiki Activity Actions

fix: allow disabling the built-in todo surface #278

Closed
nsaspy wants to merge 10 commits from fix/246-disable-todo-surface into master
pull from: fix/246-disable-todo-surface
merge into: nsaspy:master
Conversation 1 Commits 10 Files changed 6 +241 -115
nsaspy commented 2026-09-04 22:44:07 +00:00
Owner
Copy link

Fixes #246.

What

Adds a subsystem-level switch:

[todo]
enabled = false

Default remains enabled for backward compatibility.

When disabled, Zara now shuts off the built-in todo surface coherently instead of hiding only one entrypoint:

  • built-in todo LangChain tools are not registered;
  • built-in todo Python skills are hidden from discovery and reject direct execution;
  • built-in todo python_skill_intent/3 mappings are removed from Prolog resolution;
  • explicit todo search/schedule resolver shortcuts honor the same flag;
  • timer/alarm and unrelated intents remain available;
  • the legacy console applies the flag as well as AgentManager/ToolRegistry startup;
  • startup logs report that the built-in todo tools, skills, and intents are disabled;
  • an external plugin/provider can then register otherwise-colliding todo tool names.

Why

This allows zara-org-todos (lost-rob0t/zara-plugins#24) or another provider to become authoritative without Zara silently keeping a second internal todo store active.

Tests

Adds t/test_todo_surface_toggle.py covering:

  • default enabled behavior;
  • disabled tool registration;
  • disabled Python skill discovery/execution;
  • disabled Prolog todo intent resolution;
  • timer resolution remaining intact;
  • provider/plugin takeover of a built-in todo tool name;
  • rejection of non-boolean todo.enabled values.
Fixes #246. ## What Adds a subsystem-level switch: ```toml [todo] enabled = false ``` Default remains enabled for backward compatibility. When disabled, Zara now shuts off the built-in todo surface coherently instead of hiding only one entrypoint: - built-in todo LangChain tools are not registered; - built-in todo Python skills are hidden from discovery and reject direct execution; - built-in todo `python_skill_intent/3` mappings are removed from Prolog resolution; - explicit todo search/schedule resolver shortcuts honor the same flag; - timer/alarm and unrelated intents remain available; - the legacy console applies the flag as well as AgentManager/ToolRegistry startup; - startup logs report that the built-in todo tools, skills, and intents are disabled; - an external plugin/provider can then register otherwise-colliding todo tool names. ## Why This allows `zara-org-todos` (lost-rob0t/zara-plugins#24) or another provider to become authoritative without Zara silently keeping a second internal todo store active. ## Tests Adds `t/test_todo_surface_toggle.py` covering: - default enabled behavior; - disabled tool registration; - disabled Python skill discovery/execution; - disabled Prolog todo intent resolution; - timer resolution remaining intact; - provider/plugin takeover of a built-in todo tool name; - rejection of non-boolean `todo.enabled` values.
test: align todo subsystem toggle with todo.enabled
Some checks failed
CI / test (pull_request) Failing after 10s
Details
CI / android skeleton gate (pull_request) Failing after 8s
Details
CI / shared mic / Ubuntu 24.04 (pull_request) Failing after 6m21s
Details
CI / shared mic / Arch Linux (pull_request) Failing after 11m36s
Details
6ceb97ac70
nsaspy commented 2026-09-04 22:53:53 +00:00
Author
Owner
Copy link

Superseded by #270. The original six-file #246 slice was replayed onto current master because the old PR is non-mergeable and its base is 52 commits stale. None of those six paths changed upstream, and #270 requires fresh exact-head CI before merge.

Superseded by #270. The original six-file #246 slice was replayed onto current `master` because the old PR is non-mergeable and its base is 52 commits stale. None of those six paths changed upstream, and #270 requires fresh exact-head CI before merge.
nsaspy closed this pull request 2026-09-05 01:42:23 +00:00
Some checks failed
CI / test (pull_request) Failing after 10s
Details
CI / android skeleton gate (pull_request) Failing after 8s
Details
CI / shared mic / Ubuntu 24.04 (pull_request) Failing after 6m21s
Details
CI / shared mic / Arch Linux (pull_request) Failing after 11m36s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
wontfix
This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
nsaspy/zara!278
No description provided.