nsaspy/zara
1
0
Fork 0
Code Issues 95 Pull requests 18 Projects Releases Packages Wiki Activity Actions

RAGE #260: Python hooks and advice registry #255

Closed
nsaspy wants to merge 0 commits from rage/260-python-hooks-advice into master
pull from: rage/260-python-hooks-advice
merge into: nsaspy:master
Conversation 0 Commits - Files changed -
nsaspy commented 2026-09-04 22:43:51 +00:00
Owner
Copy link

Recovery wrapper for #285 because GitHub's draft→ready mutation still fails in the connector on the unsupported Repository.fullDatabaseId GraphQL field. This PR carries the identical tested head 6dee4a02abc3fba3f6750df35f5825c54c9535cc; no code changed.

Bounded #260 slice:

  • owner-aware AgentLoopAdviceRegistry for the canonical agent-loop boundary;
  • closed before / after / around / override advice kinds;
  • deterministic priority/registration ordering and snapshot dispatch;
  • owner cleanup and typed registration/dispatch failures;
  • sync/async callbacks;
  • fail-closed policy: disabled hooks are inert, and around/override require both [hooks].enabled=true and [hooks].allow_override=true;
  • no second agent loop, authorization path, config owner, or Android production change.

TDD evidence is preserved in the branch RAGE artifacts. Exact head 6dee4a02abc3fba3f6750df35f5825c54c9535cc passed CI #717, including scripts/test-all.sh, nix flake check, packaged Zara build, Android skeleton gate, and both shared-mic jobs. Opening this non-draft wrapper may trigger a fresh PR run; merge only after the exact candidate is green and review/discussion state remains clear.

Issue #260 remains open after this registry slice. User hooks.py loading, AgentManager integration, backend registry, Prolog command advice/override, plugin lifecycle cleanup, diagnostics, and wiki remain follow-on work.

Recovery wrapper for #285 because GitHub's draft→ready mutation still fails in the connector on the unsupported `Repository.fullDatabaseId` GraphQL field. This PR carries the identical tested head `6dee4a02abc3fba3f6750df35f5825c54c9535cc`; no code changed. Bounded #260 slice: - owner-aware `AgentLoopAdviceRegistry` for the canonical agent-loop boundary; - closed `before` / `after` / `around` / `override` advice kinds; - deterministic priority/registration ordering and snapshot dispatch; - owner cleanup and typed registration/dispatch failures; - sync/async callbacks; - fail-closed policy: disabled hooks are inert, and `around`/`override` require both `[hooks].enabled=true` and `[hooks].allow_override=true`; - no second agent loop, authorization path, config owner, or Android production change. TDD evidence is preserved in the branch RAGE artifacts. Exact head `6dee4a02abc3fba3f6750df35f5825c54c9535cc` passed CI #717, including `scripts/test-all.sh`, `nix flake check`, packaged Zara build, Android skeleton gate, and both shared-mic jobs. Opening this non-draft wrapper may trigger a fresh PR run; merge only after the exact candidate is green and review/discussion state remains clear. Issue #260 remains open after this registry slice. User `hooks.py` loading, AgentManager integration, backend registry, Prolog command advice/override, plugin lifecycle cleanup, diagnostics, and wiki remain follow-on work.
nsaspy closed this pull request 2026-09-04 23:10:00 +00:00
Some checks failed
CI / test (pull_request) Failing after 7s
Details
CI / android skeleton gate (pull_request) Failing after 5s
Details
CI / shared mic / Arch Linux (pull_request) Failing after 3m16s
Details
CI / shared mic / Ubuntu 24.04 (pull_request) Has been cancelled
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
wontfix
This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
nsaspy/zara!255
No description provided.