nsaspy/zara
1
0
Fork 0
Code Issues 95 Pull requests 18 Projects Releases Packages Wiki Activity Actions

RAGE #260: integrate advice with canonical agent loop #252

Closed
nsaspy wants to merge 0 commits from rage/260-agent-loop-integration into master
pull from: rage/260-agent-loop-integration
merge into: nsaspy:master
Conversation 0 Commits - Files changed -
nsaspy commented 2026-09-04 22:43:50 +00:00
Owner
Copy link

Recovery wrapper for draft #289 on the identical tested head f4b3189170ef4c7fd094f6b63937876634f71608. #289 was closed unmerged only because the GitHub draft→ready connector mutation still fails on the removed fullDatabaseId GraphQL field.

This is the same bounded core #260 slice: wire the already-merged AgentLoopAdviceRegistry around the existing AgentManager -> run_conversation_loop call only. AgentManager remains owner of turn state, approval bindings, history persistence, transient-memory cleanup, and public result shaping. No android/** changes, no user hooks.py loader, no second agent loop/backend, and no tool-policy bypass.

TDD evidence is preserved on the branch/RAGE log: deterministic RED proved the missing integration; subsequent regressions from narrow/partially-constructed config adapters were reproduced and fixed fail-closed. Exact head passed CI #751 before the latest master advance.

Because master advanced after that run, this wrapper requires a fresh pull-request CI run against current master. Do not merge if that run is pending, skipped, cancelled, failing, stale, or inconclusive. Also require mergeable state plus no blocking review/discussion.

Continues #260.

Recovery wrapper for draft #289 on the identical tested head `f4b3189170ef4c7fd094f6b63937876634f71608`. #289 was closed unmerged only because the GitHub draft→ready connector mutation still fails on the removed `fullDatabaseId` GraphQL field. This is the same bounded core #260 slice: wire the already-merged `AgentLoopAdviceRegistry` around the existing `AgentManager -> run_conversation_loop` call only. AgentManager remains owner of turn state, approval bindings, history persistence, transient-memory cleanup, and public result shaping. No `android/**` changes, no user hooks.py loader, no second agent loop/backend, and no tool-policy bypass. TDD evidence is preserved on the branch/RAGE log: deterministic RED proved the missing integration; subsequent regressions from narrow/partially-constructed config adapters were reproduced and fixed fail-closed. Exact head passed CI #751 before the latest master advance. Because master advanced after that run, this wrapper requires a fresh pull-request CI run against current master. Do not merge if that run is pending, skipped, cancelled, failing, stale, or inconclusive. Also require mergeable state plus no blocking review/discussion. Continues #260.
nsaspy closed this pull request 2026-09-04 23:10:06 +00:00
Some checks failed
CI / test (pull_request) Failing after 7s
Details
CI / android skeleton gate (pull_request) Failing after 7s
Details
CI / shared mic / Arch Linux (pull_request) Failing after 4m23s
Details
CI / shared mic / Ubuntu 24.04 (pull_request) Has been cancelled
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
wontfix
This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
nsaspy/zara!252
No description provided.