nsaspy/zara-plugins
1
0
Fork 0
Code Issues 10 Pull requests 297 Projects Releases Packages Wiki Activity Actions

fix: fail closed on unknown task-state response status #355

Open
nsaspy wants to merge 3 commits from rage/coding-task-state-status-contract into main
pull from: rage/coding-task-state-status-contract
merge into: nsaspy:main
Conversation 0 Commits 3 Files changed 2 +11
nsaspy commented 2026-09-08 02:19:30 +00:00
Owner
Copy link

Implements #252 and advances #1.

RED

35b3952a8b60144105d51fb8df57fac4eeb88c70 adds a deterministic protocol test showing an unknown symbolic task-state response status must raise CodingError instead of entering structured coding state.

Implementation

dfadd7e40237638304da78a57039663bb31560ab closes the protocol response vocabulary to ok / rejected, matching the owned Prolog task-state driver. Unknown string statuses now fail closed with an explicit compatibility error.

No cross-plugin runtime composition and no Zara Core changes.

Implements #252 and advances #1. ## RED `35b3952a8b60144105d51fb8df57fac4eeb88c70` adds a deterministic protocol test showing an unknown symbolic task-state response status must raise `CodingError` instead of entering structured coding state. ## Implementation `dfadd7e40237638304da78a57039663bb31560ab` closes the protocol response vocabulary to `ok` / `rejected`, matching the owned Prolog task-state driver. Unknown string statuses now fail closed with an explicit compatibility error. No cross-plugin runtime composition and no Zara Core changes.
merge current main into task-state status contract
Some checks failed
CI / test (pull_request) Failing after 19s
Details
079a74d282
Some checks failed
CI / test (pull_request) Failing after 19s
Details
This pull request has changes conflicting with the target branch.
  • plugins/zara-coding/lib/zara_coding/task_state.py
  • plugins/zara-coding/test/test_task_state_session.py
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin rage/coding-task-state-status-contract:rage/coding-task-state-status-contract
git switch rage/coding-task-state-status-contract

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff rage/coding-task-state-status-contract
git switch rage/coding-task-state-status-contract
git rebase main
git switch main
git merge --ff-only rage/coding-task-state-status-contract
git switch rage/coding-task-state-status-contract
git rebase main
git switch main
git merge --no-ff rage/coding-task-state-status-contract
git switch main
git merge --squash rage/coding-task-state-status-contract
git switch main
git merge --ff-only rage/coding-task-state-status-contract
git switch main
git merge rage/coding-task-state-status-contract
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
accessibility
Barrier affecting people with disabilities

  
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
security

   
wontfix
This will not be worked on

No labels
accessibility
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
security
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
nsaspy/zara-plugins!355
No description provided.