nsaspy/zara-plugins
1
0
Fork 0
Code Issues 10 Pull requests 297 Projects Releases Packages Wiki Activity Actions

fix: fence symbolic task state after protocol corruption #351

Open
nsaspy wants to merge 3 commits from rage/coding-task-state-protocol-fence into main
pull from: rage/coding-task-state-protocol-fence
merge into: nsaspy:main
Conversation 0 Commits 3 Files changed 2 +26 -10
nsaspy commented 2026-09-08 02:19:28 +00:00
Owner
Copy link

Implements #260 and advances #1.

RED

2f7d9ba5962a23ac8270768283afe984709aa09d tightens the unknown-status regression: a protocol-integrity failure must terminate the owned process, and the next operation must hit the existing crash fence rather than reuse or replace that stream.

Implementation

af141e408ac26cc20e1283d17412a24585f1b396 centralizes protocol failure handling. Broken/closed pipes, response timeout, oversized response, malformed JSON/shape and unknown statuses now terminate the owned process before raising. Because ownership remains non-null and dead, subsequent operations fail closed until explicit stop() resets the session.

This also prevents an oversized partial line from leaving tail bytes that a later command could mis-associate as its response. No Core changes or cross-plugin composition.

Implements #260 and advances #1. ## RED `2f7d9ba5962a23ac8270768283afe984709aa09d` tightens the unknown-status regression: a protocol-integrity failure must terminate the owned process, and the next operation must hit the existing crash fence rather than reuse or replace that stream. ## Implementation `af141e408ac26cc20e1283d17412a24585f1b396` centralizes protocol failure handling. Broken/closed pipes, response timeout, oversized response, malformed JSON/shape and unknown statuses now terminate the owned process before raising. Because ownership remains non-null and dead, subsequent operations fail closed until explicit `stop()` resets the session. This also prevents an oversized partial line from leaving tail bytes that a later command could mis-associate as its response. No Core changes or cross-plugin composition.
merge current main into task-state protocol fence
Some checks failed
CI / test (pull_request) Failing after 18s
Details
955bc735a3
Some checks failed
CI / test (pull_request) Failing after 18s
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin rage/coding-task-state-protocol-fence:rage/coding-task-state-protocol-fence
git switch rage/coding-task-state-protocol-fence

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff rage/coding-task-state-protocol-fence
git switch rage/coding-task-state-protocol-fence
git rebase main
git switch main
git merge --ff-only rage/coding-task-state-protocol-fence
git switch rage/coding-task-state-protocol-fence
git rebase main
git switch main
git merge --no-ff rage/coding-task-state-protocol-fence
git switch main
git merge --squash rage/coding-task-state-protocol-fence
git switch main
git merge --ff-only rage/coding-task-state-protocol-fence
git switch main
git merge rage/coding-task-state-protocol-fence
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
accessibility
Barrier affecting people with disabilities

  
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
security

   
wontfix
This will not be worked on

No labels
accessibility
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
security
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
nsaspy/zara-plugins!351
No description provided.