nsaspy/zara-plugins
1
0
Fork 0
Code Issues 10 Pull requests 297 Projects Releases Packages Wiki Activity Actions

fix(zara-discord): make startup resource-safe #222

Open
nsaspy wants to merge 10 commits from fix/zara-discord-startup-fail-closed into main
pull from: fix/zara-discord-startup-fail-closed
merge into: nsaspy:main
Conversation 0 Commits 10 Files changed 4 +161 -15
nsaspy commented 2026-09-08 02:18:49 +00:00
Owner
Copy link

Worker mailbox: #508

Bounded Plugin D IMPLEMENT slice for zara-discord startup correctness:

  • lifecycle regression tests were committed before implementation
  • missing credentials remain zero-secret/API-v1 compatible and allocate no subscriptions/workers
  • Discord client construction now happens before runtime subscription allocation, so client setup failure cannot leak a subscription
  • worker-registration failures roll back the client and subscription and clear plugin state
  • stop() clears client/subscription handles after closing them
  • log output for missing configuration uses a bounded generic reason rather than raw ConfigError text

The originally frozen “Core must distinguish unavailable from successfully started” requirement cannot be completed inside plugin API v1: ServicePlugin.start(runtime) -> None has no canonical unavailable/disabled result and the current compatibility harness intentionally starts optional plugins with no provider secrets. Exact-head CI proved that throwing on missing Discord credentials makes both source and installed compatibility fail. Core blocker: lost-rob0t/zara#658.

No secret values are logged or surfaced. No Core internals are imported.

Required gates: zara-discord tests, registry/plugin compatibility, package/Nix checks at exact head.

Worker mailbox: #508 Bounded Plugin D IMPLEMENT slice for `zara-discord` startup correctness: - lifecycle regression tests were committed before implementation - missing credentials remain zero-secret/API-v1 compatible and allocate no subscriptions/workers - Discord client construction now happens before runtime subscription allocation, so client setup failure cannot leak a subscription - worker-registration failures roll back the client and subscription and clear plugin state - `stop()` clears client/subscription handles after closing them - log output for missing configuration uses a bounded generic reason rather than raw ConfigError text The originally frozen “Core must distinguish unavailable from successfully started” requirement cannot be completed inside plugin API v1: `ServicePlugin.start(runtime) -> None` has no canonical unavailable/disabled result and the current compatibility harness intentionally starts optional plugins with no provider secrets. Exact-head CI proved that throwing on missing Discord credentials makes both source and installed compatibility fail. Core blocker: lost-rob0t/zara#658. No secret values are logged or surfaced. No Core internals are imported. Required gates: zara-discord tests, registry/plugin compatibility, package/Nix checks at exact head.
docs: sync zara-discord catalog version
Some checks failed
CI / test (pull_request) Failing after 33s
Details
CI / zara-avatar idle CPU budget (pull_request) Failing after 15m2s
Details
dd21a25d7d
Some checks failed
CI / test (pull_request) Failing after 33s
Details
CI / zara-avatar idle CPU budget (pull_request) Failing after 15m2s
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/zara-discord-startup-fail-closed:fix/zara-discord-startup-fail-closed
git switch fix/zara-discord-startup-fail-closed

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff fix/zara-discord-startup-fail-closed
git switch fix/zara-discord-startup-fail-closed
git rebase main
git switch main
git merge --ff-only fix/zara-discord-startup-fail-closed
git switch fix/zara-discord-startup-fail-closed
git rebase main
git switch main
git merge --no-ff fix/zara-discord-startup-fail-closed
git switch main
git merge --squash fix/zara-discord-startup-fail-closed
git switch main
git merge --ff-only fix/zara-discord-startup-fail-closed
git switch main
git merge fix/zara-discord-startup-fail-closed
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
accessibility
Barrier affecting people with disabilities

  
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
security

   
wontfix
This will not be worked on

No labels
accessibility
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
security
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
nsaspy/zara-plugins!222
No description provided.