nsaspy/starintel-server
1
0
Fork 0
Code Issues 49 Pull requests 7 Projects Releases Packages Wiki Activity Actions

RAGE #59: generic idempotent v1 target creation #127

Closed
lost-rob0t wants to merge 0 commits from rage/59-target-create-v1 into master
pull from: rage/59-target-create-v1
merge into: nsaspy:master
Conversation 5 Commits - Files changed -
lost-rob0t commented 2026-08-26 02:26:51 +00:00 (Migrated from github.com)
Copy link

Implements the smallest owner-side slice needed to unblock privileged clients such as the Bixby add-on without introducing a Bixby-specific backend.

Architecture boundary:

  • generic /api/v1/targets semantics, authorization and idempotency belong to StarIntel core;
  • Samsung/Bixby-specific projection remains in the optional starintel-bixby add-on;
  • no standalone Bixby gateway is introduced.

TDD state: this PR begins with tests only. The RED contract requires principal-bound deterministic idempotency, targets:dispatch authorization, a canonical contracted operation, narrow receipts, input validation, and conflict detection when the same idempotency identity is reused with changed target content.

Base captured from master: 52948721d8981e9aa5ccad4efd77185e52af845b.

Refs #59.

Implements the smallest owner-side slice needed to unblock privileged clients such as the Bixby add-on without introducing a Bixby-specific backend. Architecture boundary: - generic `/api/v1/targets` semantics, authorization and idempotency belong to StarIntel core; - Samsung/Bixby-specific projection remains in the optional `starintel-bixby` add-on; - no standalone Bixby gateway is introduced. TDD state: this PR begins with tests only. The RED contract requires principal-bound deterministic idempotency, `targets:dispatch` authorization, a canonical contracted operation, narrow receipts, input validation, and conflict detection when the same idempotency identity is reused with changed target content. Base captured from master: `52948721d8981e9aa5ccad4efd77185e52af845b`. Refs #59.
lost-rob0t commented 2026-08-26 03:04:47 +00:00 (Migrated from github.com)
Copy link

RAGE governance gate (fresh remote verification): keep this PR tests-first RED/draft only. The branch currently defines new server architecture (POST /api/v1/targets, targets:dispatch, principal-bound deterministic idempotency, receipt/conflict semantics), but I could not locate a corresponding explicitly operator-approved canonical design in lost-rob0t/starintel-auto-research. Server issue/PR prose is not design authority.

Exact current head: 68f6edb74904731053d0ca1e80395831cb873a12 (base captured as 52948721d8981e9aa5ccad4efd77185e52af845b). Smoke run 32923058732 is correctly RED: the new http-target-v1-test.lisp fails at load because STAR.FRONTENDS.HTTP-API::TARGET-V1-DOCUMENT-FROM-REQUEST is undefined, i.e. the regression is genuinely ahead of implementation. Preserve that RED evidence; do not implement or weaken it until the authoritative research -> explicit research approval -> design/adversarial review -> explicit design approval chain exists for this exact generic target API scope.

Also preserve the architecture boundary: generic StarIntel target lifecycle/idempotency belongs in core; Bixby projection stays add-on-specific; no Bixby-specific backend should be introduced absent separate approval.

RAGE governance gate (fresh remote verification): keep this PR **tests-first RED/draft only**. The branch currently defines new server architecture (`POST /api/v1/targets`, `targets:dispatch`, principal-bound deterministic idempotency, receipt/conflict semantics), but I could not locate a corresponding explicitly operator-approved canonical design in `lost-rob0t/starintel-auto-research`. Server issue/PR prose is not design authority. Exact current head: `68f6edb74904731053d0ca1e80395831cb873a12` (base captured as `52948721d8981e9aa5ccad4efd77185e52af845b`). Smoke run `32923058732` is correctly RED: the new `http-target-v1-test.lisp` fails at load because `STAR.FRONTENDS.HTTP-API::TARGET-V1-DOCUMENT-FROM-REQUEST` is undefined, i.e. the regression is genuinely ahead of implementation. Preserve that RED evidence; do not implement or weaken it until the authoritative research -> explicit research approval -> design/adversarial review -> explicit design approval chain exists for this exact generic target API scope. Also preserve the architecture boundary: generic StarIntel target lifecycle/idempotency belongs in core; Bixby projection stays add-on-specific; no Bixby-specific backend should be introduced absent separate approval.
lost-rob0t commented 2026-08-26 04:09:08 +00:00 (Migrated from github.com)
Copy link

RAGE governance update on current exact head 38666dab3610bd7771fa1c8ab3bbe67ebad0b594: the branch has crossed from tests-only RED into production implementation despite the previously pinned ADADR gate. The current diff now contains source/frontends/http-target-v1.lisp, auth/route implementation, target-dispatch changes, client contract changes, and Bixby integration. Exact-head CI is fully green (Smoke #422, Container Stack #423, Canonical schema lock #307, Operational salvage #252), but green CI is not architecture approval.

Do not merge this PR yet. The authoritative starintel-auto-research control plane still needs an explicitly operator-approved research -> design/adversarial review -> explicit design approval chain for this exact generic target-create/idempotency scope. Preserve the implementation and its green evidence as provisional realization evidence; do not fabricate retroactive approval, and do not weaken/rewrite tests merely to change governance state. Once canonical authority exists, reconcile the implementation against that exact approved design and re-verify from current master before merge.

RAGE governance update on current exact head `38666dab3610bd7771fa1c8ab3bbe67ebad0b594`: the branch has crossed from tests-only RED into production implementation despite the previously pinned ADADR gate. The current diff now contains `source/frontends/http-target-v1.lisp`, auth/route implementation, target-dispatch changes, client contract changes, and Bixby integration. Exact-head CI is fully green (Smoke #422, Container Stack #423, Canonical schema lock #307, Operational salvage #252), but green CI is not architecture approval. Do **not merge** this PR yet. The authoritative `starintel-auto-research` control plane still needs an explicitly operator-approved research -> design/adversarial review -> explicit design approval chain for this exact generic target-create/idempotency scope. Preserve the implementation and its green evidence as provisional realization evidence; do not fabricate retroactive approval, and do not weaken/rewrite tests merely to change governance state. Once canonical authority exists, reconcile the implementation against that exact approved design and re-verify from current `master` before merge.
lost-rob0t commented 2026-08-26 04:17:11 +00:00 (Migrated from github.com)
Copy link

Governance follow-up: the missing canonical target-create research/design chain now exists as draft auto-research PR lost-rob0t/starintel-auto-research#149. It adds STAR-RESEARCH-059 and STAR-SERVER-059 for the exact generic POST /api/v1/targets / targets.create scope, including canonical targets:dispatch authorization, principal-bound idempotency, dispatch-semantic fingerprinting, narrow receipts, lease separation, and the optional Bixby prepare -> explicit confirmation -> commit projection.

This does not lift the merge gate yet: both new authority documents remain REVIEW/PENDING and explicitly require operator approval. Keep #127 draft/provisional until that approval exists; then reconcile this implementation against STAR-SERVER-059 and re-run exact-head gates on current master.

Governance follow-up: the missing canonical target-create research/design chain now exists as draft auto-research PR lost-rob0t/starintel-auto-research#149. It adds STAR-RESEARCH-059 and STAR-SERVER-059 for the exact generic `POST /api/v1/targets` / `targets.create` scope, including canonical `targets:dispatch` authorization, principal-bound idempotency, dispatch-semantic fingerprinting, narrow receipts, lease separation, and the optional Bixby prepare -> explicit confirmation -> commit projection. This does **not** lift the merge gate yet: both new authority documents remain REVIEW/PENDING and explicitly require operator approval. Keep #127 draft/provisional until that approval exists; then reconcile this implementation against STAR-SERVER-059 and re-run exact-head gates on current master.
lost-rob0t commented 2026-08-26 12:08:08 +00:00 (Migrated from github.com)
Copy link

Fresh canonical governance reconciliation (Auto-Research main = 52530279e1513da61d99195d985135a9d06fe94c): the post-#149 control-plane correction explicitly removes any misleading approval signal from STAR-RESEARCH-059. Current STAR-RESEARCH-059 Generic Target Creation API and Idempotency Boundary is REVIEW with Research scope = PENDING; prior target-lease lineage is explicitly NOT APPLICABLE as approval evidence. Current STAR-SERVER-059 Generic Target Creation v1 is also REVIEW with Research basis = PENDING, Generic target-create architecture = PENDING, Security/adversarial review = PENDING, and Implementation = NOT STARTED; it names this PR as provisional realization evidence only.

Therefore #149's existence/merge must not be read as operator approval. Keep this PR draft and do not merge exact head 38666dab3610bd7771fa1c8ab3bbe67ebad0b594 despite its green Smoke #422, Container Stack #423, Canonical schema lock #307, and Operational salvage #252. The next legitimate transition is explicit operator approval of STAR-RESEARCH-059 (authorizing design review only), then explicit approval of STAR-SERVER-059 before this provisional implementation can be reconciled and realized.

Fresh canonical governance reconciliation (Auto-Research `main` = `52530279e1513da61d99195d985135a9d06fe94c`): the post-#149 control-plane correction explicitly removes any misleading approval signal from STAR-RESEARCH-059. Current `STAR-RESEARCH-059 Generic Target Creation API and Idempotency Boundary` is `REVIEW` with **Research scope = PENDING**; prior target-lease lineage is explicitly `NOT APPLICABLE` as approval evidence. Current `STAR-SERVER-059 Generic Target Creation v1` is also `REVIEW` with **Research basis = PENDING**, **Generic target-create architecture = PENDING**, **Security/adversarial review = PENDING**, and **Implementation = NOT STARTED**; it names this PR as provisional realization evidence only. Therefore #149's existence/merge must not be read as operator approval. Keep this PR draft and do **not merge** exact head `38666dab3610bd7771fa1c8ab3bbe67ebad0b594` despite its green Smoke #422, Container Stack #423, Canonical schema lock #307, and Operational salvage #252. The next legitimate transition is explicit operator approval of STAR-RESEARCH-059 (authorizing design review only), then explicit approval of STAR-SERVER-059 before this provisional implementation can be reconciled and realized.
lost-rob0t commented 2026-08-27 13:09:18 +00:00 (Migrated from github.com)
Copy link

ADARD gate reconciliation on current head 38666dab3610bd7771fa1c8ab3bbe67ebad0b594: all four PR workflows are green, and the implementation appears mergeable, but the authoritative research packet STAR-RESEARCH-059 on starintel-auto-research/main still has Research scope = PENDING. Under the current human-gated StarIntel workflow, this branch must remain unmerged until the operator explicitly approves the research conclusions, then the corresponding design is produced/reviewed and receives explicit design approval. Green CI is verification evidence only; it is not approval. Keep this PR as implementation evidence/TDD work, but do not merge it across the ADARD gate.

ADARD gate reconciliation on current head `38666dab3610bd7771fa1c8ab3bbe67ebad0b594`: all four PR workflows are green, and the implementation appears mergeable, but the authoritative research packet `STAR-RESEARCH-059` on `starintel-auto-research/main` still has `Research scope = PENDING`. Under the current human-gated StarIntel workflow, this branch must remain unmerged until the operator explicitly approves the research conclusions, then the corresponding design is produced/reviewed and receives explicit design approval. Green CI is verification evidence only; it is not approval. Keep this PR as implementation evidence/TDD work, but do not merge it across the ADARD gate.
nsaspy changed title from WIP: RAGE #59: generic idempotent v1 target creation to RAGE #59: generic idempotent v1 target creation 2026-08-28 03:29:49 +00:00
nsaspy closed this pull request 2026-09-04 14:38:16 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
wontfix
This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
nsaspy/starintel-server!127
No description provided.