nsaspy/hackmode
1
0
Fork 0
Code Issues 46 Pull requests 55 Projects Releases Packages Wiki Activity Actions

Core: repair find-apis arity regression #159

Open
nsaspy wants to merge 3 commits from hackmode-rage-hackpert/fix-find-apis-core-gate into master
pull from: hackmode-rage-hackpert/fix-find-apis-core-gate
merge into: nsaspy:master
Conversation 0 Commits 3 Files changed 3 +21 -1
nsaspy commented 2026-09-04 20:58:43 +00:00
Owner
Copy link

Bug-first blocker

Exact-head core CI for #101 exposed an existing clean-compile regression in functions.lisp: find-apis calls find-api with three arguments even though find-api accepts a URL object plus one optional pattern list. The same call also references an unbound pattern variable.

RED

This draft first wires a focused collection contract proving find-apis classifies each URL using the caller-supplied pattern set while leaving non-matches untagged. Current production code still fails the Common Lisp compile gate before that regression can run.

Boundary

Minimal core correctness repair only. No database internals, provider/effect widening, expert authority changes, scheduler changes, or StarIntel product work.

## Bug-first blocker Exact-head core CI for #101 exposed an existing clean-compile regression in `functions.lisp`: `find-apis` calls `find-api` with three arguments even though `find-api` accepts a URL object plus one optional pattern list. The same call also references an unbound `pattern` variable. ## RED This draft first wires a focused collection contract proving `find-apis` classifies each URL using the caller-supplied pattern set while leaving non-matches untagged. Current production code still fails the Common Lisp compile gate before that regression can run. ## Boundary Minimal core correctness repair only. No database internals, provider/effect widening, expert authority changes, scheduler changes, or StarIntel product work.
Core: repair find-apis collection dispatch
Some checks failed
agent-pr-serialization / one-open-pr-per-agent-lane (pull_request_target) Failing after 1s
Details
agent-framework-boundary / keep-agent-framework-out-of-product-tree (pull_request) Successful in 4s
Details
core / common-lisp-core (pull_request) Failing after 33s
Details
monorepo / hygiene (pull_request) Successful in 6m38s
Details
3c96ed3eb0
Some checks failed
agent-pr-serialization / one-open-pr-per-agent-lane (pull_request_target) Failing after 1s
Details
agent-framework-boundary / keep-agent-framework-out-of-product-tree (pull_request) Successful in 4s
Details
core / common-lisp-core (pull_request) Failing after 33s
Details
monorepo / hygiene (pull_request) Successful in 6m38s
Details
This pull request has changes conflicting with the target branch.
  • source/hackmode-core/hackmode-tests.asd
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin hackmode-rage-hackpert/fix-find-apis-core-gate:hackmode-rage-hackpert/fix-find-apis-core-gate
git switch hackmode-rage-hackpert/fix-find-apis-core-gate

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff hackmode-rage-hackpert/fix-find-apis-core-gate
git switch hackmode-rage-hackpert/fix-find-apis-core-gate
git rebase master
git switch master
git merge --ff-only hackmode-rage-hackpert/fix-find-apis-core-gate
git switch hackmode-rage-hackpert/fix-find-apis-core-gate
git rebase master
git switch master
git merge --no-ff hackmode-rage-hackpert/fix-find-apis-core-gate
git switch master
git merge --squash hackmode-rage-hackpert/fix-find-apis-core-gate
git switch master
git merge --ff-only hackmode-rage-hackpert/fix-find-apis-core-gate
git switch master
git merge hackmode-rage-hackpert/fix-find-apis-core-gate
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
feature
New feature or capability

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
refactor
Code cleanup without behavior change

  
wontfix
This will not be worked on

No labels
bug
documentation
duplicate
enhancement
feature
good first issue
help wanted
invalid
question
refactor
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
nsaspy/hackmode!159
No description provided.