nsaspy/hackmode
1
0
Fork 0
Code Issues 46 Pull requests 55 Projects Releases Packages Wiki Activity Actions

Hackpert: defend inspection snapshots from mutable string aliasing #155

Open
nsaspy wants to merge 4 commits from hackpert/inspection-defensive-string-copies into master
pull from: hackpert/inspection-defensive-string-copies
merge into: nsaspy:master
Conversation 0 Commits 4 Files changed 3 +110 -33
nsaspy commented 2026-09-04 20:58:41 +00:00
Owner
Copy link

Slice

Bug-first hardening of Hackpert operator inspection snapshots for #27/#29.

Current inspection APIs copy list structure but still expose mutable Common Lisp string leaves directly; copy-tree also leaves strings aliased. The regression requires both source-string snapshot isolation and defensive string copies on returned run/action inspection data.

No provider execution, persistence/database internals, authority changes, scheduler, or StarIntel product work.

RED contract head: 9e246b9a394da60d8cc4ad045e1296f3283a2a0e.

## Slice Bug-first hardening of Hackpert operator inspection snapshots for #27/#29. Current inspection APIs copy list structure but still expose mutable Common Lisp string leaves directly; `copy-tree` also leaves strings aliased. The regression requires both source-string snapshot isolation and defensive string copies on returned run/action inspection data. No provider execution, persistence/database internals, authority changes, scheduler, or StarIntel product work. RED contract head: `9e246b9a394da60d8cc4ad045e1296f3283a2a0e`.
fix: return defensive run inspection strings
Some checks failed
agent-pr-serialization / one-open-pr-per-agent-lane (pull_request_target) Failing after 2s
Details
agent-framework-boundary / keep-agent-framework-out-of-product-tree (pull_request) Successful in 7s
Details
core / common-lisp-core (pull_request) Failing after 39s
Details
monorepo / hygiene (pull_request) Successful in 6m46s
Details
b7f991ac76
Some checks failed
agent-pr-serialization / one-open-pr-per-agent-lane (pull_request_target) Failing after 2s
Details
agent-framework-boundary / keep-agent-framework-out-of-product-tree (pull_request) Successful in 7s
Details
core / common-lisp-core (pull_request) Failing after 39s
Details
monorepo / hygiene (pull_request) Successful in 6m46s
Details
This pull request has changes conflicting with the target branch.
  • source/hackmode-core/expert/inspection.lisp
  • source/hackmode-core/hackmode-tests.asd
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin hackpert/inspection-defensive-string-copies:hackpert/inspection-defensive-string-copies
git switch hackpert/inspection-defensive-string-copies

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff hackpert/inspection-defensive-string-copies
git switch hackpert/inspection-defensive-string-copies
git rebase master
git switch master
git merge --ff-only hackpert/inspection-defensive-string-copies
git switch hackpert/inspection-defensive-string-copies
git rebase master
git switch master
git merge --no-ff hackpert/inspection-defensive-string-copies
git switch master
git merge --squash hackpert/inspection-defensive-string-copies
git switch master
git merge --ff-only hackpert/inspection-defensive-string-copies
git switch master
git merge hackpert/inspection-defensive-string-copies
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
feature
New feature or capability

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
refactor
Code cleanup without behavior change

  
wontfix
This will not be worked on

No labels
bug
documentation
duplicate
enhancement
feature
good first issue
help wanted
invalid
question
refactor
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
nsaspy/hackmode!155
No description provided.