nsaspy/hackmode
1
0
Fork 0
Code Issues 46 Pull requests 55 Projects Releases Packages Wiki Activity Actions

Hackpert: defend loop scope strings from caller mutation #150

Open
nsaspy wants to merge 3 commits from hackmode-rage-hackpert/29-loop-scope-defensive-copy into master
pull from: hackmode-rage-hackpert/29-loop-scope-defensive-copy
merge into: nsaspy:master
Conversation 0 Commits 3 Files changed 3 +70 -15
nsaspy commented 2026-09-04 20:58:39 +00:00
Owner
Copy link

Slice

Bug-first hardening for #29 / #27.

expert-loop-state currently retains caller-owned operation/run strings and exposes those mutable strings through generated accessors. A caller can therefore rewrite the scope identity after state construction, undermining later operation/run scope validation.

This PR starts RED-first with a regression proving both constructor aliasing and accessor aliasing. The implementation will make loop scope identity an owned defensive snapshot without changing reasoning strategy, authority, provider execution, persistence, or database internals.

Boundary

  • Hackpert-owned loop state only.
  • No source/hackmode-database/** changes.
  • No StarIntel product work.
  • No new executor, database, graph store, or KB authority.
## Slice Bug-first hardening for #29 / #27. `expert-loop-state` currently retains caller-owned operation/run strings and exposes those mutable strings through generated accessors. A caller can therefore rewrite the scope identity after state construction, undermining later operation/run scope validation. This PR starts RED-first with a regression proving both constructor aliasing and accessor aliasing. The implementation will make loop scope identity an owned defensive snapshot without changing reasoning strategy, authority, provider execution, persistence, or database internals. ## Boundary - Hackpert-owned loop state only. - No `source/hackmode-database/**` changes. - No StarIntel product work. - No new executor, database, graph store, or KB authority.
fix: own defensive expert loop scope snapshots
Some checks failed
agent-pr-serialization / one-open-pr-per-agent-lane (pull_request_target) Failing after 1s
Details
agent-framework-boundary / keep-agent-framework-out-of-product-tree (pull_request) Successful in 22s
Details
core / common-lisp-core (pull_request) Failing after 1m3s
Details
monorepo / hygiene (pull_request) Successful in 3m16s
Details
a13e9cab27
Some checks failed
agent-pr-serialization / one-open-pr-per-agent-lane (pull_request_target) Failing after 1s
Details
agent-framework-boundary / keep-agent-framework-out-of-product-tree (pull_request) Successful in 22s
Details
core / common-lisp-core (pull_request) Failing after 1m3s
Details
monorepo / hygiene (pull_request) Successful in 3m16s
Details
This pull request has changes conflicting with the target branch.
  • source/hackmode-core/expert/loop.lisp
  • source/hackmode-core/tests/expert-loop-scope-copy.lisp
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin hackmode-rage-hackpert/29-loop-scope-defensive-copy:hackmode-rage-hackpert/29-loop-scope-defensive-copy
git switch hackmode-rage-hackpert/29-loop-scope-defensive-copy

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff hackmode-rage-hackpert/29-loop-scope-defensive-copy
git switch hackmode-rage-hackpert/29-loop-scope-defensive-copy
git rebase master
git switch master
git merge --ff-only hackmode-rage-hackpert/29-loop-scope-defensive-copy
git switch hackmode-rage-hackpert/29-loop-scope-defensive-copy
git rebase master
git switch master
git merge --no-ff hackmode-rage-hackpert/29-loop-scope-defensive-copy
git switch master
git merge --squash hackmode-rage-hackpert/29-loop-scope-defensive-copy
git switch master
git merge --ff-only hackmode-rage-hackpert/29-loop-scope-defensive-copy
git switch master
git merge hackmode-rage-hackpert/29-loop-scope-defensive-copy
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
feature
New feature or capability

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
refactor
Code cleanup without behavior change

  
wontfix
This will not be worked on

No labels
bug
documentation
duplicate
enhancement
feature
good first issue
help wanted
invalid
question
refactor
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
nsaspy/hackmode!150
No description provided.