nsaspy/hackmode
1
0
Fork 0
Code Issues 46 Pull requests 55 Projects Releases Packages Wiki Activity Actions

Hackpert: harden objective identity snapshots #142

Open
nsaspy wants to merge 2 commits from hackpert/issue-29-objective-identity-aliasing into master
pull from: hackpert/issue-29-objective-identity-aliasing
merge into: nsaspy:master
Conversation 0 Commits 2 Files changed 2 +43 -6
nsaspy commented 2026-09-04 20:58:36 +00:00
Owner
Copy link

Issue

Advances #29 with a bug-first regression in the objective/SPEC identity boundary.

Bug

expert-objective is immutable-by-interface, but its generated id / version accessors exposed stored mutable strings directly and the constructor retained caller-owned identity strings. A caller could rewrite objective identity after construction, poisoning plan/objective matching and extension selection without any canonical mutation path.

RED

Exact test-only head af3821c48c4f2cddd6698c56cf756927f72671a9 reached Load Hackmode and run ASDF tests with all setup/dependency steps green, then common-lisp-core failed on the new aliasing regression.

GREEN

Exact implementation head 1cdf5bd754e31319448a3fbd0838a2de39f3b8ff passed common-lisp-core, monorepo/hygiene, and agent-framework-boundary.

Implementation

  • objective storage uses private raw accessors;
  • objective ID/version strings are snapshotted at construction;
  • public ID/version accessors return independent copies;
  • existing clause/limit/capability access remains behind the same public API.

No provider execution, database persistence internals, authority widening, scheduler changes, or StarIntel product work.

## Issue Advances #29 with a bug-first regression in the objective/SPEC identity boundary. ## Bug `expert-objective` is immutable-by-interface, but its generated `id` / `version` accessors exposed stored mutable strings directly and the constructor retained caller-owned identity strings. A caller could rewrite objective identity after construction, poisoning plan/objective matching and extension selection without any canonical mutation path. ## RED Exact test-only head `af3821c48c4f2cddd6698c56cf756927f72671a9` reached `Load Hackmode and run ASDF tests` with all setup/dependency steps green, then `common-lisp-core` failed on the new aliasing regression. ## GREEN Exact implementation head `1cdf5bd754e31319448a3fbd0838a2de39f3b8ff` passed `common-lisp-core`, monorepo/hygiene, and `agent-framework-boundary`. ## Implementation - objective storage uses private raw accessors; - objective ID/version strings are snapshotted at construction; - public ID/version accessors return independent copies; - existing clause/limit/capability access remains behind the same public API. No provider execution, database persistence internals, authority widening, scheduler changes, or StarIntel product work.
fix: isolate objective identity snapshots
Some checks failed
agent-pr-serialization / one-open-pr-per-agent-lane (pull_request_target) Failing after 1s
Details
agent-framework-boundary / keep-agent-framework-out-of-product-tree (pull_request) Successful in 17s
Details
core / common-lisp-core (pull_request) Failing after 1m15s
Details
monorepo / hygiene (pull_request) Successful in 1m47s
Details
1cdf5bd754
Some checks failed
agent-pr-serialization / one-open-pr-per-agent-lane (pull_request_target) Failing after 1s
Details
agent-framework-boundary / keep-agent-framework-out-of-product-tree (pull_request) Successful in 17s
Details
core / common-lisp-core (pull_request) Failing after 1m15s
Details
monorepo / hygiene (pull_request) Successful in 1m47s
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin hackpert/issue-29-objective-identity-aliasing:hackpert/issue-29-objective-identity-aliasing
git switch hackpert/issue-29-objective-identity-aliasing

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff hackpert/issue-29-objective-identity-aliasing
git switch hackpert/issue-29-objective-identity-aliasing
git rebase master
git switch master
git merge --ff-only hackpert/issue-29-objective-identity-aliasing
git switch hackpert/issue-29-objective-identity-aliasing
git rebase master
git switch master
git merge --no-ff hackpert/issue-29-objective-identity-aliasing
git switch master
git merge --squash hackpert/issue-29-objective-identity-aliasing
git switch master
git merge --ff-only hackpert/issue-29-objective-identity-aliasing
git switch master
git merge hackpert/issue-29-objective-identity-aliasing
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
feature
New feature or capability

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
refactor
Code cleanup without behavior change

  
wontfix
This will not be worked on

No labels
bug
documentation
duplicate
enhancement
feature
good first issue
help wanted
invalid
question
refactor
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
nsaspy/hackmode!142
No description provided.