nsaspy/zara-plugins
1
0
Fork 0
Code Issues 10 Pull requests 297 Projects Releases Packages Wiki Activity Actions

fix: reject scalar zara-shell policy collections #297

Open
nsaspy wants to merge 0 commits from rage/370-shell-policy-collections into main
pull from: rage/370-shell-policy-collections
merge into: nsaspy:main
Conversation 0 Commits - Files changed -
nsaspy commented 2026-09-08 02:19:12 +00:00
Owner
Copy link

Closes #370.

RED

A scalar allowed_roots="/tmp" currently iterates into /, t, m, p; resolving that collection can accidentally introduce / as an allowed root. RED coverage also checks scalar program/environment collections.

Implementation

  • requires program/environment allowlists to be set/frozenset collections;
  • requires allowed roots to be a tuple;
  • retains the existing element validation and configured plugin construction path.

No execution widening or private cancellation plane. Exact-head CI must pass the full compatibility, registry, plugin-test, and Nix gate before merge.

Closes #370. ## RED A scalar `allowed_roots="/tmp"` currently iterates into `/`, `t`, `m`, `p`; resolving that collection can accidentally introduce `/` as an allowed root. RED coverage also checks scalar program/environment collections. ## Implementation - requires program/environment allowlists to be set/frozenset collections; - requires allowed roots to be a tuple; - retains the existing element validation and configured plugin construction path. No execution widening or private cancellation plane. Exact-head CI must pass the full compatibility, registry, plugin-test, and Nix gate before merge.
Some checks failed
CI / test (pull_request) Failing after 39s
Details
This branch is already included in the target branch. There is nothing to merge.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin rage/370-shell-policy-collections:rage/370-shell-policy-collections
git switch rage/370-shell-policy-collections

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff rage/370-shell-policy-collections
git switch rage/370-shell-policy-collections
git rebase main
git switch main
git merge --ff-only rage/370-shell-policy-collections
git switch rage/370-shell-policy-collections
git rebase main
git switch main
git merge --no-ff rage/370-shell-policy-collections
git switch main
git merge --squash rage/370-shell-policy-collections
git switch main
git merge --ff-only rage/370-shell-policy-collections
git switch main
git merge rage/370-shell-policy-collections
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
accessibility
Barrier affecting people with disabilities

  
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
security

   
wontfix
This will not be worked on

No labels
accessibility
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
security
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
nsaspy/zara-plugins!297
No description provided.