nsaspy/zara-plugins
1
0
Fork 0
Code Issues 10 Pull requests 297 Projects Releases Packages Wiki Activity Actions

fix: validate avatar state directory policy #254

Open
nsaspy wants to merge 0 commits from rage/447-avatar-directory-policy into main
pull from: rage/447-avatar-directory-policy
merge into: nsaspy:main
Conversation 0 Commits - Files changed -
nsaspy commented 2026-09-08 02:18:59 +00:00
Owner
Copy link

Closes #447.

RED was proven on replayed head eaaf603b424890a0fad482c6b1636d7a07e598ea: source/install compatibility and the real Electron gate passed while the registry/plugin-test stage failed on malformed avatar_directory types.

GREEN now requires avatar_directory to be a non-empty string before mutable avatar state paths are constructed and documents that boundary.

Exact GREEN head 306a1c2a5626cb154813a484d14efdcea5466103 passed CI #934: whitespace, compatibility-contract tests, source compatibility, installed compatibility, complete registry/plugin tests, generated Nix package builds, and the real Electron/Xvfb idle-CPU gate. Zero unresolved review threads.

Closes #447. RED was proven on replayed head `eaaf603b424890a0fad482c6b1636d7a07e598ea`: source/install compatibility and the real Electron gate passed while the registry/plugin-test stage failed on malformed `avatar_directory` types. GREEN now requires `avatar_directory` to be a non-empty string before mutable avatar state paths are constructed and documents that boundary. Exact GREEN head `306a1c2a5626cb154813a484d14efdcea5466103` passed CI #934: whitespace, compatibility-contract tests, source compatibility, installed compatibility, complete registry/plugin tests, generated Nix package builds, and the real Electron/Xvfb idle-CPU gate. Zero unresolved review threads.
Some checks failed
CI / test (pull_request) Failing after 6s
Details
CI / zara-avatar idle CPU budget (pull_request) Failing after 9m52s
Details
This branch is already included in the target branch. There is nothing to merge.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin rage/447-avatar-directory-policy:rage/447-avatar-directory-policy
git switch rage/447-avatar-directory-policy

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff rage/447-avatar-directory-policy
git switch rage/447-avatar-directory-policy
git rebase main
git switch main
git merge --ff-only rage/447-avatar-directory-policy
git switch rage/447-avatar-directory-policy
git rebase main
git switch main
git merge --no-ff rage/447-avatar-directory-policy
git switch main
git merge --squash rage/447-avatar-directory-policy
git switch main
git merge --ff-only rage/447-avatar-directory-policy
git switch main
git merge rage/447-avatar-directory-policy
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
accessibility
Barrier affecting people with disabilities

  
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
security

   
wontfix
This will not be worked on

No labels
accessibility
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
security
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
nsaspy/zara-plugins!254
No description provided.