[P0-02] Repair the test system and make zero executed tests a hard failure #10

New issue

Closed

opened 2026-07-22 00:09:07 +00:00 by lost-rob0t · 0 comments

lost-rob0t commented

2026-07-22 00:09:07 +00:00

(Migrated from github.com)

Confirmed defects

dev:t/package.lisp imports the misspelled, nonexistent star:*injest-workers*; the actual setting is *ingest-workers*. It also imports actor/runtime symbols from star.actors that are inherited but not exported. The test ASDF system therefore cannot be trusted to load consistently.

The CI smoke workflow only proves nix run .#star-smoke exited successfully. It does not independently verify suite/test discovery counts, and the repository documentation says service-dependent tests may be skipped.

Required changes

Fix package imports and exported test support APIs.
Make asdf:test-system :starintel-gserver-tests the canonical entry point.
Report discovered, executed, passed, failed, and skipped counts per suite.
Fail when any required suite discovers or executes zero tests.
Separate hermetic unit tests from explicit integration tests requiring RabbitMQ/CouchDB.
Remove silent service-unavailable skips from required CI.
Add a compile/load test for every ASDF system and package.

Acceptance tests

The test system loads from a clean image.
Intentionally renaming an imported symbol makes CI fail.
An empty required suite makes CI fail.
Unit tests run without external services.
Integration tests provision dependencies and fail when dependencies are unavailable.

## Confirmed defects `dev:t/package.lisp` imports the misspelled, nonexistent `star:*injest-workers*`; the actual setting is `*ingest-workers*`. It also imports actor/runtime symbols from `star.actors` that are inherited but not exported. The test ASDF system therefore cannot be trusted to load consistently. The CI smoke workflow only proves `nix run .#star-smoke` exited successfully. It does not independently verify suite/test discovery counts, and the repository documentation says service-dependent tests may be skipped. ## Required changes - Fix package imports and exported test support APIs. - Make `asdf:test-system :starintel-gserver-tests` the canonical entry point. - Report discovered, executed, passed, failed, and skipped counts per suite. - Fail when any required suite discovers or executes zero tests. - Separate hermetic unit tests from explicit integration tests requiring RabbitMQ/CouchDB. - Remove silent service-unavailable skips from required CI. - Add a compile/load test for every ASDF system and package. ## Acceptance tests 1. The test system loads from a clean image. 2. Intentionally renaming an imported symbol makes CI fail. 3. An empty required suite makes CI fail. 4. Unit tests run without external services. 5. Integration tests provision dependencies and fail when dependencies are unavailable.