Remove unsafe ad hoc STAR URI implementation from runtime modernization #2
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Confirmed defects at PR #1 head
e3d5646bbp/star_uri.py:197-218documents that callers must supply a canonical authority, butparse_legacy_star_uri(value)accepts no target authority, discards the legacy address, and inventslegacy.<domain>. This contradicts STAR-RESEARCH-041, which requires an explicit migration target because the tuple cannot determine canonical identity._normalize_segmentchecks./..before percent normalization (:100-111), sostar://a/actor/%2E%2Eis accepted and serializes asstar://a/actor/... Other accepted strings such as%61also serialize differently whileis_canonical_star_urireturns true. A local exact-head probe reproduced all three outcomes.Config.DEFAULT_STAR_AUTHORITY = "bbpd.starintel.actor"treats an illustrative research namespace as an owned deployment default; no ownership decision was established.Impact
The PR would emit invented/noncanonical identities and create migration behavior outside this debugging task. Forgejo exact-head CI was also failure, so the branch was not merge eligible.
Expected resolution
Remove the parser, authority default, and startup STAR manifest from this runtime debugging PR. Implement STAR URI only through the shared conformance/migration work tracked by starintel-server issue #1, with explicit migration targets and authority ownership. Keep dual Rabbit target bindings and actor-event fields as independent wire fixes.
Regression criteria
star://implementation or default authority.%2E/%2E%2Eand noncanonical spellings are covered by the eventual shared conformance suite.Research
Corrected STAR-RESEARCH-060 on
research/star-bbpd-runtime-modernizationexplicitly withdraws its prior recommendation.