Expand CI to test the real monorepo, web stack, and UI parity #14

New issue

Closed

opened 2026-07-30 04:07:06 +00:00 by lost-rob0t · 0 comments

lost-rob0t commented

2026-07-30 04:07:06 +00:00

(Migrated from github.com)

Problem

PR #3 reports green CI, but the workflow validates a reduced surface that does not match the documented developer or production paths.

Current CI:

installs dependencies directly inside frontend/ instead of testing the root setup;
lints only frontend/src/control-plane;
runs only five selected Vitest files;
skips the existing full unit suite;
skips integration tests;
skips Playwright/E2E tests;
does not load quasar-web;
does not start CLOG or the WebSocket server;
does not test production asset hosting.

This is why CI missed the broken npm run dev path and Lisp web startup defects.

Found during review of PR #3.

Required changes

Make CI use the same root install and commands documented for developers.
Run full frontend lint, typecheck, static checks, boundary checks, unit tests, and integration tests.
Run Playwright for critical desktop and mobile paths.
Load and test quasar-web.
Add a complete stack smoke test.
Add a browser integration test proving:
1. UI connects to Lisp;
2. document is created through the real UI path;
3. graph membership/node appears;
4. browser reload occurs;
5. authoritative state is restored from Lisp/store.
Add a production build/serve smoke test.
Add explicit tests for transaction rollback, event sequencing, reconnect snapshot recovery, store persistence, and workspace isolation.
Remove stale monorepo/submodule statements from documentation and test that README commands remain executable where practical.

Acceptance criteria

A fresh-checkout CI job runs the same root install and test commands as README.
The complete frontend unit and integration suites pass.
Critical Playwright tests pass against the real stack.
CI starts and stops the Lisp web application.
CI fails when root npm run dev, WebSocket startup, or CLOG production serving is broken.
Green CI establishes the actual PR definition of done rather than only adapter-module syntax.

Related PR: #3

## Problem PR #3 reports green CI, but the workflow validates a reduced surface that does not match the documented developer or production paths. Current CI: - installs dependencies directly inside `frontend/` instead of testing the root setup; - lints only `frontend/src/control-plane`; - runs only five selected Vitest files; - skips the existing full unit suite; - skips integration tests; - skips Playwright/E2E tests; - does not load `quasar-web`; - does not start CLOG or the WebSocket server; - does not test production asset hosting. This is why CI missed the broken `npm run dev` path and Lisp web startup defects. Found during review of PR #3. ## Required changes - Make CI use the same root install and commands documented for developers. - Run full frontend lint, typecheck, static checks, boundary checks, unit tests, and integration tests. - Run Playwright for critical desktop and mobile paths. - Load and test `quasar-web`. - Add a complete stack smoke test. - Add a browser integration test proving: 1. UI connects to Lisp; 2. document is created through the real UI path; 3. graph membership/node appears; 4. browser reload occurs; 5. authoritative state is restored from Lisp/store. - Add a production build/serve smoke test. - Add explicit tests for transaction rollback, event sequencing, reconnect snapshot recovery, store persistence, and workspace isolation. - Remove stale monorepo/submodule statements from documentation and test that README commands remain executable where practical. ## Acceptance criteria - A fresh-checkout CI job runs the same root install and test commands as README. - The complete frontend unit and integration suites pass. - Critical Playwright tests pass against the real stack. - CI starts and stops the Lisp web application. - CI fails when root `npm run dev`, WebSocket startup, or CLOG production serving is broken. - Green CI establishes the actual PR definition of done rather than only adapter-module syntax. Related PR: #3