Hackpert: defend transition reason inspection strings #81

Closed

nsaspy wants to merge 2 commits from hackmode-rage-hackpert/transition-reason-copy into master

nsaspy commented

2026-09-04 20:37:03 +00:00

Owner

Slice

Bug-first Hackpert operator-inspection hardening for #29/#27.

expert-loop-transition-inspection already defensively copies operation/run scope, but a mutable string decision reason was still stored and returned by alias. That let source or caller mutation rewrite a supposedly side-effect-free historical transition snapshot.

RED contract commit: 74900d58537ea798de9a1bbce28863c5c6449222 — core failed on the new aliasing regression while monorepo and boundary passed.

GREEN implementation head: e01da8f61ec2913ba86bdc91e3786a40ae879d40 — core, monorepo, and agent-framework-boundary all passed at exact head.

This non-draft PR replaces draft #117 at the identical green head because GitHub's ready-for-review GraphQL mutation failed on the connector's recurring fullDatabaseId field bug.

Scope is confined to Hackpert transition inspection/tests; no database persistence internals, provider execution, or StarIntel product work.

## Slice Bug-first Hackpert operator-inspection hardening for #29/#27. `expert-loop-transition-inspection` already defensively copies operation/run scope, but a mutable string decision reason was still stored and returned by alias. That let source or caller mutation rewrite a supposedly side-effect-free historical transition snapshot. RED contract commit: `74900d58537ea798de9a1bbce28863c5c6449222` — core failed on the new aliasing regression while monorepo and boundary passed. GREEN implementation head: `e01da8f61ec2913ba86bdc91e3786a40ae879d40` — core, monorepo, and agent-framework-boundary all passed at exact head. This non-draft PR replaces draft #117 at the identical green head because GitHub's ready-for-review GraphQL mutation failed on the connector's recurring `fullDatabaseId` field bug. Scope is confined to Hackpert transition inspection/tests; no database persistence internals, provider execution, or StarIntel product work.

nsaspy added 2 commits

2026-09-04 20:37:03 +00:00