nsaspy/hackmode
1
0
Fork 0
Code Issues 46 Pull requests 55 Projects Releases Packages Wiki Activity Actions

test: require defensive direct candidate accessors #151

Closed
nsaspy wants to merge 2 commits from rage-hackpert/direct-candidate-defensive-access-11 into master
pull from: rage-hackpert/direct-candidate-defensive-access-11
merge into: nsaspy:master
Conversation 1 Commits 2 Files changed 2 +53 -5
nsaspy commented 2026-09-04 20:58:40 +00:00
Owner
Copy link

Bug-first Hackpert slice for #29/#27.

make-expert-direct-candidate copies constructor inputs, but the generated accessors still expose the stored mutable operation/run strings and payload/provenance trees. This RED-first regression mutates values returned by those accessors and requires the normalized candidate to remain unchanged.

The intended fix is confined to the Hackpert direct-candidate boundary. It will not add provider execution, canonical mutation, persistence/database authority, a second scheduler, or StarIntel product work.

Bug-first Hackpert slice for #29/#27. `make-expert-direct-candidate` copies constructor inputs, but the generated accessors still expose the stored mutable operation/run strings and payload/provenance trees. This RED-first regression mutates values returned by those accessors and requires the normalized candidate to remain unchanged. The intended fix is confined to the Hackpert direct-candidate boundary. It will not add provider execution, canonical mutation, persistence/database authority, a second scheduler, or StarIntel product work.
fix: return defensive direct candidate snapshots
Some checks failed
agent-pr-serialization / one-open-pr-per-agent-lane (pull_request_target) Failing after 1s
Details
agent-framework-boundary / keep-agent-framework-out-of-product-tree (pull_request) Successful in 18s
Details
core / common-lisp-core (pull_request) Failing after 51s
Details
monorepo / hygiene (pull_request) Successful in 2m33s
Details
37dbcb78da
nsaspy closed this pull request 2026-09-05 07:56:32 +00:00
nsaspy commented 2026-09-21 20:11:51 +00:00
Author
Owner
Copy link

Agent PR serialization closed this PR because #172 is the newer open rage-hackpert/ lane PR. One open PR per configured agent lane is allowed.

Agent PR serialization closed this PR because #172 is the newer open `rage-hackpert/` lane PR. One open PR per configured agent lane is allowed.
Some checks failed
agent-pr-serialization / one-open-pr-per-agent-lane (pull_request_target) Failing after 1s
Details
agent-framework-boundary / keep-agent-framework-out-of-product-tree (pull_request) Successful in 18s
Details
core / common-lisp-core (pull_request) Failing after 51s
Details
monorepo / hygiene (pull_request) Successful in 2m33s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
feature
New feature or capability

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
refactor
Code cleanup without behavior change

  
wontfix
This will not be worked on

No labels
bug
documentation
duplicate
enhancement
feature
good first issue
help wanted
invalid
question
refactor
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
nsaspy/hackmode!151
No description provided.